Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix list commands #102

Merged
merged 5 commits into from
Oct 12, 2020
Merged

Fix list commands #102

merged 5 commits into from
Oct 12, 2020

Conversation

zhaojj2209
Copy link

Resolves #99.

@zhaojj2209 zhaojj2209 added type.enhancement 👍 New feature or request priority.medium 🥈 Todo for current iteration labels Oct 12, 2020
@zhaojj2209 zhaojj2209 added this to the v1.2 milestone Oct 12, 2020
@zhaojj2209 zhaojj2209 requested a review from a team October 12, 2020 13:30
@codecov-io
Copy link

codecov-io commented Oct 12, 2020 •
edited

Codecov Report

Merging #102 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #102      +/-   ##
============================================
- Coverage     68.07%   67.99%   -0.08%     
+ Complexity      489      485       -4     
============================================
  Files            91       91              
  Lines          1657     1653       -4     
  Branches        155      155              
============================================
- Hits           1128     1124       -4     
  Misses          485      485              
  Partials         44       44
Impacted Files Coverage Δ Complexity Δ
...s2103_w16_3/finesse/model/transaction/Expense.java 100.00% <ø> (ø) 1.00 <0.00> (-2.00)
...cs2103_w16_3/finesse/model/transaction/Income.java 100.00% <ø> (ø) 1.00 <0.00> (-2.00)
...6_3/finesse/logic/commands/ListExpenseCommand.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...16_3/finesse/logic/commands/ListIncomeCommand.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c8d933...e84dfaa. Read the comment docs.

yongping827
yongping827 previously approved these changes Oct 12, 2020
View reviewed changes
Copy link

@yongping827 yongping827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ianyong
ianyong approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@ianyong ianyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

yongping827
yongping827 approved these changes Oct 12, 2020
View reviewed changes
Copy link

@yongping827 yongping827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongping827 yongping827 merged commit cc0c703 into AY2021S1-CS2103T-W16-3:master Oct 12, 2020
@zhaojj2209 zhaojj2209 added type.bug 🐛 Something isn't working and removed type.enhancement 👍 New feature or request labels Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wltan wltan wltan left review comments

@ianyong ianyong ianyong approved these changes

@yongping827 yongping827 yongping827 approved these changes

Assignees
No one assigned
Labels
priority.medium 🥈 Todo for current iteration type.bug 🐛 Something isn't working
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

List commands not working for Expenses and Income panels
5 participants
@zhaojj2209 @codecov-io @ianyong @wltan @yongping827