Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify TypicalTransactions.getTypicalFinanceTracker #103

Merged

Conversation

yongping827
Copy link

@yongping827 yongping827 commented Oct 12, 2020

Modified TypicalTransactions.getTypicalFinanceTracker to call the methods getTypicalExpenses and getTypicalIncomes, in addition to getTypicalTransactions.

This is to allow tests that use getTypicalFinanceTracker to easily access its components if required.

@yongping827 yongping827 added priority.low 🥉 Not so important, can be left for a future iteration type.task 📋 Miscellaneous tasks that aren't feature or documentation-related labels Oct 12, 2020
@codecov-io
Copy link

Codecov Report

Merging #103 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #103      +/-   ##
============================================
+ Coverage     67.90%   68.07%   +0.17%     
- Complexity      483      489       +6     
============================================
  Files            90       91       +1     
  Lines          1648     1657       +9     
  Branches        154      155       +1     
============================================
+ Hits           1119     1128       +9     
  Misses          485      485              
  Partials         44       44              
Impacted Files Coverage Δ Complexity Δ
...16_3/finesse/logic/commands/ListIncomeCommand.java 100.00% <0.00%> (ø) 2.00% <0.00%> (ø%)
...6_3/finesse/logic/commands/ListExpenseCommand.java 100.00% <0.00%> (ø) 2.00% <0.00%> (ø%)
...finesse/logic/commands/ListTransactionCommand.java 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...6_3/finesse/logic/parser/FinanceTrackerParser.java 94.73% <0.00%> (+0.79%) 26.00% <0.00%> (+4.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad2cbda...1b2f883. Read the comment docs.

Copy link

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ianyong ianyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ianyong ianyong merged commit 93c66d2 into AY2021S1-CS2103T-W16-3:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.low 🥉 Not so important, can be left for a future iteration type.task 📋 Miscellaneous tasks that aren't feature or documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants