-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify 'edit' command to depend on UI state #107
Modify 'edit' command to depend on UI state #107
Conversation
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
============================================
+ Coverage 67.99% 69.10% +1.10%
- Complexity 485 512 +27
============================================
Files 91 93 +2
Lines 1653 1738 +85
Branches 155 165 +10
============================================
+ Hits 1124 1201 +77
+ Misses 485 484 -1
- Partials 44 53 +9
Continue to review full report at Codecov.
|
src/main/java/ay2021s1_cs2103_w16_3/finesse/logic/commands/EditCommand.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes:
edit
command that returns one of the 2 specialisededit
commands depending on UI state.FinanceTracker
.addExpense
andaddIncome
methods ofModelManager
updating the wrong list.Resolves #86.