Add tests to increase code coverage for 'model' components #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To achieve 100% test coverage for Amount
To achieve 100% test coverage for Date
To achieve 100% test coverage for TransactionList
Use more realistic transactions instead of persons
To achieve 100% line coverage for Transaction
To achieve 100% test coverage for FinanceTracker
To achieve 100% test coverage for UserPrefs
ianyong
added
priority.medium 🥈
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
============================================
+ Coverage 71.44% 72.99% +1.54%
- Complexity 541 556 +15
============================================
Files 90 90
Lines 1653 1655 +2
Branches 161 161
============================================
+ Hits 1181 1208 +27
+ Misses 421 397 -24
+ Partials 51 50 -1
Continue to review full report at Codecov.
|
zhaojj2209
reviewed
Oct 18, 2020
src/test/data/JsonSerializableFinanceTrackerTest/typicalTransactionsFinanceTracker.json
Show resolved
Hide resolved
src/main/java/ay2021s1_cs2103_w16_3/finesse/model/util/SampleDataUtil.java
Show resolved
Hide resolved
To achieve 100% test coverage for SampleDataUtil
ianyong
force-pushed
the
ian/add-model-tests
branch
from
0b9a58e
to
a277a8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
TypicalTransactionsto be transactions instead of persons.Related to #115.