Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Model and Storage sections in Developer Guide #143

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Update Model and Storage sections in Developer Guide #143

merged 2 commits into from
Oct 20, 2020

Conversation

yongping827
Copy link

Model:

  • Add information describing how transaction lists are implemented in FinanceTracker and ModelManager

Storage:

  • Add information about JsonAdaptedExpense and JsonAdaptedIncome
  • Add information describing how transaction lists are implemented in JsonSerializableFinanceTracker
  • Update UML class diagram for storage

@yongping827 yongping827 added type.documentation 🧻 Improvements or additions to documentation priority.medium 🥈 Todo for current iteration labels Oct 20, 2020
@yongping827 yongping827 added this to the v1.3 milestone Oct 20, 2020
ianyong
ianyong requested changes Oct 20, 2020
View reviewed changes
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 20, 2020 •
edited

Codecov Report

Merging #143 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #143      +/-   ##
============================================
+ Coverage     72.16%   72.18%   +0.01%     
  Complexity      535      535              
============================================
  Files            88       88              
  Lines          1613     1614       +1     
  Branches        154      155       +1     
============================================
+ Hits           1164     1165       +1     
  Misses          396      396              
  Partials         53       53
Impacted Files Coverage Δ Complexity Δ
...16_3/finesse/logic/parser/DeleteCommandParser.java 100.00% <0.00%> (ø) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f710333...69d05e4. Read the comment docs.

ianyong
ianyong approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@ianyong ianyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

wltan
wltan approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@wltan wltan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wltan wltan merged commit ce3f825 into master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianyong ianyong ianyong approved these changes

@wltan wltan wltan approved these changes

Assignees
No one assigned
Labels
priority.medium 🥈 Todo for current iteration type.documentation 🧻 Improvements or additions to documentation
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yongping827 @codecov-io @ianyong @wltan