Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tabs #161

Merged
merged 7 commits into from
Oct 23, 2020
Merged

Refactor tabs #161

merged 7 commits into from
Oct 23, 2020

Conversation

ianyong
Copy link
Member

@ianyong ianyong commented Oct 23, 2020

Changes:

  • Refactor tabs.
    • Previously, the tabs were implemented by intercepting click events and manually updating the various UI components.
    • Currently, the tabs have their own content panes that get loaded on selecting the respective tab.
      • OverviewTabPane
      • IncomeTabPane
      • ExpenseTabPane
      • AnalyticsTabPane
  • Remove hard-coded programmatic updating of tab label CSS.
    • Add .tab:hover style instead.
  • Add highlighting of tabs on hover.
    • To provide feedback to the user for better UX.
  • Convert Help tab to a button.
    • Previously, it functioned as a button even though the underlying JavaFX element was Tab. This only worked because the tabs were not implemented correctly.
    • Add the Help button to the right of the tabs so as to distinguish it from the tabs.
      • This was achieved through the use of an AnchorPane.
  • Update uiState whenever the selected tab changes through a listener instead.
  • Merge handleTabHelp and handleCommandHelp into handleHelp.
    • Two functions providing the same functionality is useless.
  • Add blank Canvas for Analytics tab.

Resolves #153.

@ianyong ianyong added priority.medium 🥈 Todo for current iteration type.task 📋 Miscellaneous tasks that aren't feature or documentation-related labels Oct 23, 2020
@ianyong ianyong added this to the v1.3 milestone Oct 23, 2020
@ianyong ianyong requested a review from a team October 23, 2020 16:02
siddarth2824
siddarth2824 approved these changes Oct 23, 2020
View reviewed changes
Copy link

@siddarth2824 siddarth2824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

zhaojj2209
zhaojj2209 approved these changes Oct 23, 2020
View reviewed changes
Copy link

@zhaojj2209 zhaojj2209 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Future work: make the UI resizable with a minimum aspect ratio.

@zhaojj2209 zhaojj2209 merged commit fb63b27 into master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddarth2824 siddarth2824 siddarth2824 approved these changes

@zhaojj2209 zhaojj2209 zhaojj2209 approved these changes

Assignees
No one assigned
Labels
priority.medium 🥈 Todo for current iteration type.task 📋 Miscellaneous tasks that aren't feature or documentation-related
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Refactor tabs
3 participants
@ianyong @siddarth2824 @zhaojj2209