-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional commands for Frequent Income feature #166
Add additional commands for Frequent Income feature #166
Conversation
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
============================================
+ Coverage 74.76% 76.08% +1.31%
- Complexity 701 770 +69
============================================
Files 124 131 +7
Lines 2128 2262 +134
Branches 226 242 +16
============================================
+ Hits 1591 1721 +130
+ Misses 448 447 -1
- Partials 89 94 +5
Continue to review full report at Codecov.
|
82a6a8b
to
76d29cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is good from a UX perspective that the user is able to convert incomes (and expenses also) from a list that is not even visible to them.
What I envision is that these commands should be restricted to their respective tabs (as is the case for edit
and delete
currently). Then, we can add a generic command that is simpler to use (also the case for edit
and delete
currently).
But that can be addressed in a future issue. The logic behind the commands LGTM!
Edit: You may want to check if #158, #159, #160 should be tagged type.story
instead.
.../java/ay2021s1_cs2103_w16_3/finesse/logic/commands/frequent/DeleteFrequentIncomeCommand.java
Show resolved
Hide resolved
src/main/java/ay2021s1_cs2103_w16_3/finesse/model/frequent/FrequentIncomeList.java
Show resolved
Hide resolved
...1s1_cs2103_w16_3/finesse/logic/commands/frequentcommands/EditFrequentExpenseCommandTest.java
Outdated
Show resolved
Hide resolved
...21s1_cs2103_w16_3/finesse/logic/commands/frequentcommands/EditFrequentIncomeCommandTest.java
Outdated
Show resolved
Hide resolved
...103_w16_3/finesse/logic/commands/frequentcommands/EditFrequentTransactionDescriptorTest.java
Outdated
Show resolved
Hide resolved
...103_w16_3/finesse/logic/commands/frequentcommands/EditFrequentTransactionDescriptorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/ay2021s1_cs2103_w16_3/finesse/model/frequent/FrequentIncomeListTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #158.
Resolves #159.
Resolves #160.
Changes:
EditFrequentIncomeCommand
for users to edit existing frequent incomesDeleteFrequentIncomeCommand
for users to delete existing frequent incomesConvertFrequentIncomeCommand
for users to convert the specified frequent income and add it to the finance trackers as an incomeEditFrequentIncomeCommand
DeleteFrequentIncomeCommand
ConvertFrequentIncomeCommand
EditFrequentIncomrCommandParser
DeletetFrequentIncomrCommandParser
ConvertFrequentIncomrCommandParser
Future Work:
EditFrequentIncomeCommand
,DeleteFrequentIncomeCommand
andConvertFrequentIncomeCommand
only under theIncome
tab