Refactor add command for frequent expense and frequent income #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarth2824
added
type.enhancement 👍
yongping827
requested changes
Oct 25, 2020
| @@ -47,7 +52,8 @@ public CommandResult execute(Model model) throws CommandException { | |||
| } catch (DuplicateFrequentTransactionException e) { | |||
| throw new CommandException(e.getMessage()); | |||
| } | |||
| return new CommandResult(String.format(MESSAGE_SUCCESS, toAdd)); | |||
| Tab tabToSwitchTo = Tab.values()[EXPENSE_TAB_INDEX.getZeroBased()]; | |||
| return new CommandResult(String.format(MESSAGE_SUCCESS, toAdd), tabToSwitchTo); | |||
There was a problem hiding this comment.
Suggested change
| return new CommandResult(String.format(MESSAGE_SUCCESS, toAdd), tabToSwitchTo); | |
| return new CommandResult(String.format(MESSAGE_SUCCESS, toAdd), Tab.EXPENSES); |
Same for AddFrequentIncomeCommand as well.
This will remove the need to have an Index field to specify which Tab to switch to.
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
=========================================
Coverage 73.66% 73.66%
Complexity 787 787
=========================================
Files 129 129
Lines 2442 2442
Branches 254 254
=========================================
Hits 1799 1799
Misses 547 547
Partials 96 96
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #182.
Changes:
CommandResultupon creating a newAddFrequentExpenseCommand. The newCommandResultcontains the index of theExpense Tabto switch to.CommandResultupon creating a newAddFrequentIncomeCommand. The newCommandResultcontains the index of theIncome Tabto switch to.