Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restrictions to command inputs #201

Merged

Conversation

zhaojj2209
Copy link

Resolves #200.

Restricts user command inputs to one title/amount/date for adding transactions, one amount/date for finding transactions, and one amount for setting expense limit/saving goal.
Additional restrictions placed on find command such that the lower bound for amount/date should not be larger than the upper bound.

@zhaojj2209 zhaojj2209 added type.enhancement 👍 New feature or request priority.medium 🥈 Todo for current iteration labels Oct 27, 2020
@zhaojj2209 zhaojj2209 added this to the v1.3 milestone Oct 27, 2020
@zhaojj2209 zhaojj2209 requested a review from a team October 27, 2020 14:21
@codecov-io
Copy link

Codecov Report

Merging #201 into master will decrease coverage by 0.29%.
The diff coverage is 58.62%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #201      +/-   ##
============================================
- Coverage     72.98%   72.68%   -0.30%     
- Complexity      824      835      +11     
============================================
  Files           134      134              
  Lines          2539     2596      +57     
  Branches        282      299      +17     
============================================
+ Hits           1853     1887      +34     
- Misses          580      597      +17     
- Partials        106      112       +6     
Impacted Files Coverage Δ Complexity Δ
...cs2103_w16_3/finesse/model/transaction/Amount.java 85.71% <ø> (ø) 11.00 <0.00> (ø)
...3_w16_3/finesse/model/transaction/Transaction.java 100.00% <ø> (ø) 10.00 <0.00> (ø)
..._w16_3/finesse/logic/parser/FindCommandParser.java 24.63% <27.27%> (+3.01%) 5.00 <1.00> (+1.00)
.../finesse/logic/parser/AddExpenseCommandParser.java 100.00% <100.00%> (ø) 7.00 <0.00> (+3.00)
...3/finesse/logic/parser/AddIncomeCommandParser.java 100.00% <100.00%> (ø) 7.00 <0.00> (+3.00)
...3_w16_3/finesse/logic/parser/ArgumentMultimap.java 100.00% <100.00%> (ø) 10.00 <2.00> (+2.00)
...er/budgetparsers/SetExpenseLimitCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (+1.00)
...ser/budgetparsers/SetSavingsGoalCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a679f2...00095c3. Read the comment docs.

yongping827
yongping827 previously approved these changes Oct 27, 2020
Copy link

@yongping827 yongping827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaojj2209
Copy link
Author

Future work:

  • Add the same restrictions to the edit income/expense commands.
  • Add input restrictions for bookmark income/expense commands.

Co-authored-by: Ian Yong <ianyongyc@gmail.com>
Copy link
Member

@ianyong ianyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@yongping827 yongping827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianyong ianyong merged commit 8a570be into AY2021S1-CS2103T-W16-3:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.medium 🥈 Todo for current iteration type.enhancement 👍 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add restrictions to command inputs
4 participants