-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add restrictions to command inputs #201
Add restrictions to command inputs #201
Conversation
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
============================================
- Coverage 72.98% 72.68% -0.30%
- Complexity 824 835 +11
============================================
Files 134 134
Lines 2539 2596 +57
Branches 282 299 +17
============================================
+ Hits 1853 1887 +34
- Misses 580 597 +17
- Partials 106 112 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Future work:
|
src/test/java/ay2021s1_cs2103_w16_3/finesse/logic/parser/AddIncomeCommandParserTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ian Yong <ianyongyc@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #200.
Restricts user command inputs to one title/amount/date for adding transactions, one amount/date for finding transactions, and one amount for setting expense limit/saving goal.
Additional restrictions placed on find command such that the lower bound for amount/date should not be larger than the upper bound.