Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UI scalability #226

Merged
merged 10 commits into from
Oct 29, 2020
Merged

Improve UI scalability #226

merged 10 commits into from
Oct 29, 2020

Conversation

ianyong
Copy link
Member

@ianyong ianyong commented Oct 29, 2020 •
edited

Changes:

  • Remove StatusBarFooter.
  • Make image on saving goals panel scale properly.
  • Center text on saving goals panel and adjust padding accordingly.
  • Stack transaction titles over categories.
  • Bind the width of transaction cards to their container's width.
  • Add ScrollPane to handle transactions with too many categories to display.
    • Hijack scrolling when hovering over a ScrollPane so as to allow horizontal scrolling.
  • Center text in category labels.
  • Increase the size of bookmarked transactions.
  • Increase the size of the command display box.
    • It can now show up to 4 lines.
  • Reduce the size of tabs.
  • Reduce spacing in general.
  • Rename side panels for consistency.
    • Bookmarked Incomes -> Bookmark Incomes
    • Bookmarked Expenses -> Bookmark Expenses

Resolves #223.

@ianyong ianyong added type.enhancement 👍 New feature or request priority.medium 🥈 Todo for current iteration labels Oct 29, 2020
@ianyong ianyong added this to the v1.4 milestone Oct 29, 2020
@ianyong ianyong requested a review from a team October 29, 2020 18:49
@ianyong
Rename side panels for consistency
109fa13 
'Bookmarked Incomes' -> 'Bookmark Incomes'
'Bookmarked Expenses' -> 'Bookmark Expenses'
yongping827
yongping827 approved these changes Oct 29, 2020
View reviewed changes
Copy link

@yongping827 yongping827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhaojj2209
zhaojj2209 approved these changes Oct 29, 2020
View reviewed changes
Copy link

@zhaojj2209 zhaojj2209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaojj2209 zhaojj2209 merged commit 50c66b7 into master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaojj2209 zhaojj2209 zhaojj2209 approved these changes

@yongping827 yongping827 yongping827 approved these changes

Assignees
No one assigned
Labels
priority.medium 🥈 Todo for current iteration type.enhancement 👍 New feature or request
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Ensure UI scales properly
3 participants
@ianyong @zhaojj2209 @yongping827