-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly list out printable ASCII characters #257
Conversation
Also update the constraints messages to be more descriptive.
6dd2661
to
0e3c7b9
Compare
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
=========================================
Coverage 71.58% 71.58%
Complexity 897 897
=========================================
Files 141 141
Lines 2819 2819
Branches 330 330
=========================================
Hits 2018 2018
Misses 682 682
Partials 119 119
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however do note that the issue is currently autolinked to close #131, which might not be intended.
src/test/java/ay2021s1_cs2103_w16_3/finesse/model/category/CategoryTest.java
Show resolved
Hide resolved
src/test/java/ay2021s1_cs2103_w16_3/finesse/model/transaction/TitleTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changes:
abbr
HTML tag.Title
andCategory
to be more informative.Title
andCategory
.Addresses #131 (comment).