-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce no arguments for single-word commands #281
Conversation
src/test/java/ay2021s1_cs2103_w16_3/finesse/logic/parser/FinanceTrackerParserTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
============================================
+ Coverage 71.17% 71.22% +0.05%
- Complexity 920 921 +1
============================================
Files 141 141
Lines 2859 2871 +12
Branches 337 338 +1
============================================
+ Hits 2035 2045 +10
- Misses 703 704 +1
- Partials 121 122 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changes:
clear
exit
help
list
(including variants)Note that I did not end up using the parsers as it would result in a lot of repetitive code. In addition, using the parsers would mean that the error message that is shown cannot be customised to display the entered command, as there would be no way of disambiguating between the various
list
variants.Fixes #280.