Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate checks #72

Conversation

zhaojj2209
Copy link

@zhaojj2209 zhaojj2209 commented Oct 6, 2020

Resolves #68.
Allows duplicate transactions to be added to the finance tracker by removing duplicate checks. Redundant methods such as isSameTransaction have also been removed. Since UniqueTransactionList no longer needs to be unique, it has been renamed to TransactionList.

@zhaojj2209 zhaojj2209 added priority.medium 🥈 Todo for current iteration type.task 📋 Miscellaneous tasks that aren't feature or documentation-related labels Oct 6, 2020
@zhaojj2209 zhaojj2209 added this to the v1.2 milestone Oct 6, 2020
@zhaojj2209 zhaojj2209 requested a review from a team October 6, 2020 08:17
@zhaojj2209 zhaojj2209 added this to In progress in Fine$$e (General) via automation Oct 6, 2020
@zhaojj2209 zhaojj2209 removed this from In progress in Fine$$e (General) Oct 6, 2020
Copy link
Member

@ianyong ianyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@yongping827 yongping827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongping827 yongping827 merged commit e640da7 into AY2021S1-CS2103T-W16-3:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.medium 🥈 Todo for current iteration type.task 📋 Miscellaneous tasks that aren't feature or documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate check
3 participants