-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify storage to handle expense and income #76
Modify storage to handle expense and income #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pitest report: https://ay2021s1-cs2103t-w16-3.github.io/reports/pitest/202010081253/
Note that the mutation coverage for ExpenseList
and IncomeList
is not very good, as the tests are based on the original AB3. It would be good if we could take a brief look to see if it can be improved, but not a hard requirement at the moment.
src/test/java/ay2021s1_cs2103_w16_3/finesse/testutil/TypicalTransactions.java
Outdated
Show resolved
Hide resolved
src/test/java/ay2021s1_cs2103_w16_3/finesse/testutil/TypicalTransactions.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=========================================
Coverage ? 70.10%
Complexity ? 450
=========================================
Files ? 82
Lines ? 1495
Branches ? 141
=========================================
Hits ? 1048
Misses ? 410
Partials ? 37
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for now. As noted in the PR description more work is needed before #59 is resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Next steps:
- Remodel Model and Logic such that Expense is added to ExpenseList and Income is added to IncomeList
- Make the correct list display in the correct tab in the UI
- Remove TransactionList and make Transaction an abstract class
Partially addresses #59.
JSON
data files now require"transactions"
,"expenses"
and"incomes"
fields."transactions"
will be removed in a future PR. Loading and saving of current data reflects this structure.Adding expenses and incomes does not work yet, since they are still added to transaction list, instead of expense and income lists.