Add 'tab' command #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianyong
added
type.enhancement 👍
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
============================================
- Coverage 69.18% 69.04% -0.15%
- Complexity 458 470 +12
============================================
Files 83 85 +2
Lines 1548 1586 +38
Branches 143 145 +2
============================================
+ Hits 1071 1095 +24
- Misses 438 449 +11
- Partials 39 42 +3
Continue to review full report at Codecov.
|
zhaojj2209
requested changes
Oct 11, 2020
| Index index = ParserUtil.parseIndex(args); | ||
| if (index.getOneBased() > TabCommand.NUM_OF_TABS) { | ||
| throw new ParseException( | ||
| String.format(MESSAGE_INVALID_COMMAND_FORMAT, TabCommand.MESSAGE_TAB_DOES_NOT_EXIST)); |
There was a problem hiding this comment.
Currently, inputting tab 5 will return the same error message as other invalid formats instead of MESSAGE_TAB_DOES_NOT_EXIST.
This is in line with the EditCommand and DeleteCommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
tabcommand.tab <1-based index of tab>FinanceTrackerParserTest.Resolves #89.