Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Test Coverage and add test files #100

Merged
merged 2 commits into from
Oct 12, 2020

Conversation

YuunoKun
Copy link

Improve Test Coverage.
Add new EnterSessionCommand/EnterSessionCommandParser test files

Add new EnterSessionCommand/EnterSessionCommandParser test files
@YuunoKun YuunoKun added this to the v1.2.1 milestone Oct 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #100 into master will increase coverage by 4.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
+ Coverage     71.35%   75.96%   +4.60%     
- Complexity      655      718      +63     
============================================
  Files           109      109              
  Lines          2067     2068       +1     
  Branches        225      225              
============================================
+ Hits           1475     1571      +96     
+ Misses          524      442      -82     
+ Partials         68       55      -13     
Impacted Files Coverage Δ Complexity Δ
src/main/java/atas/commons/core/Messages.java 75.00% <ø> (ø) 2.00 <0.00> (ø)
...logic/commands/sessionlist/EditSessionCommand.java 92.85% <ø> (+7.14%) 14.00 <0.00> (ø)
...gic/commands/sessionlist/ClearSessionsCommand.java 100.00% <100.00%> (ø) 3.00 <1.00> (+1.00)
...gic/commands/sessionlist/DeleteSessionCommand.java 100.00% <100.00%> (+38.46%) 8.00 <1.00> (+5.00)
...mmands/sessionlist/session/ParticipateCommand.java 94.11% <100.00%> (+11.76%) 8.00 <0.00> (+1.00)
.../commands/sessionlist/session/PresenceCommand.java 94.44% <100.00%> (+11.11%) 8.00 <0.00> (+1.00)
...ttendance/exceptions/SessionNotFoundException.java 100.00% <100.00%> (+100.00%) 1.00 <1.00> (+1.00)
src/main/java/atas/logic/parser/ParserUtil.java 97.67% <0.00%> (+4.65%) 17.00% <0.00%> (+1.00%)
...rc/main/java/atas/model/attendance/Attributes.java 85.71% <0.00%> (+4.76%) 11.00% <0.00%> (+1.00%)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 544a9f5...7dd3aea. Read the comment docs.

Copy link

@nweiyue nweiyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice coverage for the test cases

Copy link

@erisjacey erisjacey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisjacey erisjacey merged commit 5a551fd into AY2021S1-CS2103T-W16-4:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants