Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit help window #101

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Conversation

nweiyue
Copy link

@nweiyue nweiyue commented Oct 11, 2020

Update help window to contain all commands.
Future styling can be implement.

@nweiyue nweiyue added this to the v1.2.1 milestone Oct 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #101 into master will increase coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #101      +/-   ##
============================================
+ Coverage     71.15%   71.32%   +0.16%     
- Complexity      650      655       +5     
============================================
  Files           109      109              
  Lines          2063     2068       +5     
  Branches        224      225       +1     
============================================
+ Hits           1468     1475       +7     
+ Misses          528      525       -3     
- Partials         67       68       +1     
Impacted Files Coverage Δ Complexity Δ
...logic/commands/sessionlist/EditSessionCommand.java 85.71% <ø> (ø) 14.00 <0.00> (ø)
...ogic/commands/sessionlist/EnterSessionCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...a/atas/logic/commands/studentlist/EditCommand.java 96.87% <ø> (ø) 13.00 <0.00> (ø)
src/main/java/atas/ui/HelpWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/atas/storage/JsonAdaptedSession.java 72.09% <0.00%> (-3.52%) 8.00% <0.00%> (ø%)
src/main/java/atas/model/attendance/Session.java 89.06% <0.00%> (+0.17%) 26.00% <0.00%> (ø%)
.../main/java/atas/storage/JsonAdaptedAttributes.java 64.00% <0.00%> (+5.66%) 10.00% <0.00%> (+1.00%)
src/main/java/atas/model/attendance/Presence.java 63.63% <0.00%> (+9.09%) 7.00% <0.00%> (+1.00%)
...main/java/atas/model/attendance/Participation.java 63.63% <0.00%> (+9.09%) 7.00% <0.00%> (+1.00%)
...rc/main/java/atas/model/attendance/Attributes.java 80.95% <0.00%> (+9.52%) 10.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6c7668...9c09351. Read the comment docs.

Copy link

@erisjacey erisjacey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisjacey erisjacey merged commit aee7c74 into AY2021S1-CS2103T-W16-4:master Oct 12, 2020
@nweiyue nweiyue linked an issue Oct 13, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Help command
3 participants