Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random generator #112

Merged
merged 13 commits into from
Oct 18, 2020
Merged

Conversation

erisjacey
Copy link

No description provided.

@erisjacey erisjacey added this to the v1.3 milestone Oct 15, 2020
@codecov-io
Copy link

codecov-io commented Oct 15, 2020

Codecov Report

Merging #112 into master will increase coverage by 0.01%.
The diff coverage is 82.35%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #112      +/-   ##
============================================
+ Coverage     74.92%   74.94%   +0.01%     
- Complexity      708      714       +6     
============================================
  Files           112      114       +2     
  Lines          2070     2087      +17     
  Branches        220      221       +1     
============================================
+ Hits           1551     1564      +13     
- Misses          466      467       +1     
- Partials         53       56       +3     
Impacted Files Coverage Δ Complexity Δ
src/main/java/atas/logic/parser/AtasParser.java 94.44% <0.00%> (-5.56%) 22.00 <0.00> (ø)
src/main/java/atas/model/Model.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/main/java/atas/ui/HelpWindow.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...main/java/atas/logic/commands/atas/RngCommand.java 77.77% <77.77%> (ø) 2.00 <2.00> (?)
...java/atas/commons/core/random/RandomGenerator.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/main/java/atas/model/ModelManager.java 94.62% <100.00%> (+0.11%) 38.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45cb205...47782ae. Read the comment docs.

@YuunoKun YuunoKun linked an issue Oct 16, 2020 that may be closed by this pull request
Copy link

@marcustw marcustw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some query for the 2 test files.

Copy link

@marcustw marcustw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erisjacey erisjacey merged commit 312f4b3 into AY2021S1-CS2103T-W16-4:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add random number generator
3 participants