Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor addressBookFilePath => studentListFilePath #120

Merged
merged 4 commits into from
Oct 17, 2020

Conversation

erisjacey
Copy link

@erisjacey erisjacey commented Oct 17, 2020

Also enable assertions in build.gradle

@erisjacey erisjacey added this to the v1.3 milestone Oct 17, 2020
Copy link

@nweiyue nweiyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-io
Copy link

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #120   +/-   ##
=========================================
  Coverage     74.92%   74.92%           
  Complexity      708      708           
=========================================
  Files           112      112           
  Lines          2070     2070           
  Branches        220      220           
=========================================
  Hits           1551     1551           
  Misses          466      466           
  Partials         53       53           
Impacted Files Coverage Δ Complexity Δ
src/main/java/atas/commons/core/LogsCenter.java 78.37% <ø> (ø) 10.00 <0.00> (ø)
src/main/java/atas/model/UserPrefs.java 81.57% <85.71%> (ø) 12.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335548a...cd70d94. Read the comment docs.

@erisjacey erisjacey merged commit 45cb205 into AY2021S1-CS2103T-W16-4:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants