Update DG #126
Update DG #126
Conversation
docs/DeveloperGuide.md
Outdated
|
|
||
| Step 3. `SwitchCommandParser#parse()` checks if there is an argument being passed by the user. If an argument is passed, a `SwitchCommand` will be created and `SwitchCommand#execute()` will be called by the `LogicManager`. | ||
|
|
||
| <div markdown="span" class="alert alert-info">:information_source: **Note:** If no arguments is found, a `ParseException` will be thrown and the execution terminates. |
There was a problem hiding this comment.
Perhaps "If no arguments are found" ?
docs/DeveloperGuide.md
Outdated
|
|
||
| </div><br> | ||
|
|
||
| Step 4. `SwitchCommand#execute()` will check if the argument pass is an existing tab name. If the argument is valid, a `CommandResult` containing a variable `switchTab` with the value of the target `Tab` will be returned to `MainWindow`. |
There was a problem hiding this comment.
Perhaps "if the argument passed in is an"?
There was a problem hiding this comment.
Thanks for spotting the mistakes!
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=========================================
Coverage 74.33% 74.33%
Complexity 747 747
=========================================
Files 117 117
Lines 2194 2194
Branches 228 228
=========================================
Hits 1631 1631
Misses 505 505
Partials 58 58 Continue to review full report at Codecov.
|
|
|
||
| </div><br> | ||
|
|
||
| Step 4. `SwitchCommand#execute()` will check if the argument passed in is an existing tab name. If the argument is valid, a `CommandResult` containing a variable `switchTab` with the value of the target `Tab` will be return to `MainWindow`. |
There was a problem hiding this comment.
Perhaps can combine "If the argument is valid" with no argument ==> If argument is invalid, a ParseException...?
There was a problem hiding this comment.
Thanks for the suggestion but if the argument is invalid, it throws a CommandException but if argument is empty it throws a ParseException. Hence, this is why I separated them.
There was a problem hiding this comment.
Thanks for the suggestion but if the argument is invalid, it throws a CommandException but if argument is empty it throws a ParseException. Hence, this is why I separated them.
Noted thanks for clarification
Update Ui component
Add switch tabs implementation