Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index range bug #138

Merged

Conversation

nweiyue
Copy link

@nweiyue nweiyue commented Oct 23, 2020

  • participate 0, presence 0 throws exception
  • participate INDEX_OUT_OF_RANGE, presence INDEX_OUT_OF_RANGE throws exception
  • participate 3-0, presence 3-0 (first number bigger than the second) throws exception

@nweiyue nweiyue added this to the v1.3 milestone Oct 23, 2020
@nweiyue nweiyue added the type.Bug A bug label Oct 23, 2020
@codecov-io
Copy link

Codecov Report

Merging #138 into master will decrease coverage by 0.14%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #138      +/-   ##
============================================
- Coverage     74.15%   74.01%   -0.15%     
+ Complexity      746      745       -1     
============================================
  Files           117      117              
  Lines          2198     2197       -1     
  Branches        229      230       +1     
============================================
- Hits           1630     1626       -4     
- Misses          506      507       +1     
- Partials         62       64       +2     
Impacted Files Coverage Δ Complexity Δ
src/main/java/atas/commons/core/Messages.java 75.00% <ø> (ø) 2.00 <0.00> (ø)
...mmands/sessionlist/session/ParticipateCommand.java 85.00% <33.33%> (-9.12%) 8.00 <0.00> (ø)
.../commands/sessionlist/session/PresenceCommand.java 85.71% <33.33%> (-8.74%) 8.00 <0.00> (ø)
src/main/java/atas/logic/parser/ParserUtil.java 97.72% <100.00%> (+0.05%) 17.00 <1.00> (ø)
...va/atas/logic/parser/ParticipateCommandParser.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
.../java/atas/logic/parser/PresenceCommandParser.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...rc/main/java/atas/model/attendance/IndexRange.java 95.65% <100.00%> (-1.02%) 14.00 <2.00> (-2.00)
src/main/java/atas/model/ModelManager.java 95.95% <0.00%> (+1.01%) 42.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 029ed11...a8d7af1. Read the comment docs.

Copy link

@erisjacey erisjacey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nweiyue nweiyue merged commit b06bb6a into AY2021S1-CS2103T-W16-4:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants