Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.3.1 fix addstu same email #140

Merged

Conversation

marcustw
Copy link

@marcustw marcustw commented Oct 24, 2020

Fix addstu same email

Add test cases for equals in EmailTest and MatriculationTest

@codecov-io
Copy link

codecov-io commented Oct 24, 2020

Codecov Report

Merging #140 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #140      +/-   ##
============================================
- Coverage     73.81%   73.79%   -0.02%     
  Complexity      814      814              
============================================
  Files           125      125              
  Lines          2402     2404       +2     
  Branches        243      245       +2     
============================================
+ Hits           1773     1774       +1     
  Misses          556      556              
- Partials         73       74       +1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/atas/model/student/Student.java 97.22% <100.00%> (+0.16%) 18.00 <0.00> (+1.00)
...logic/commands/studentlist/EditStudentCommand.java 95.38% <0.00%> (-1.54%) 12.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5d908...806f1fe. Read the comment docs.

@marcustw marcustw linked an issue Oct 24, 2020 that may be closed by this pull request
@marcustw marcustw added the type.Bug A bug label Oct 24, 2020
Copy link

@nweiyue nweiyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erisjacey erisjacey added this to the v1.3 milestone Oct 24, 2020
@marcustw marcustw merged commit ce67d21 into AY2021S1-CS2103T-W16-4:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow adding students with same email address
4 participants