Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.3.0 update ug #155

Merged
merged 5 commits into from
Oct 26, 2020
Merged

Conversation

YuunoKun
Copy link

Update UG

@YuunoKun YuunoKun added this to the v1.3 milestone Oct 25, 2020
@codecov-io
Copy link

codecov-io commented Oct 25, 2020

Codecov Report

Merging #155 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #155      +/-   ##
============================================
- Coverage     75.15%   75.11%   -0.04%     
- Complexity      913      914       +1     
============================================
  Files           131      131              
  Lines          2652     2656       +4     
  Branches        270      271       +1     
============================================
+ Hits           1993     1995       +2     
- Misses          578      580       +2     
  Partials         81       81              
Impacted Files Coverage Δ Complexity Δ
.../java/atas/model/statistics/StudentStatistics.java 87.50% <0.00%> (-4.17%) 18.00% <0.00%> (-1.00%)
src/main/java/atas/ui/HelpWindow.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
src/main/java/atas/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...n/java/atas/logic/parser/AddNoteCommandParser.java 100.00% <0.00%> (ø) 3.00% <0.00%> (ø%)
src/main/java/atas/logic/parser/AtasParser.java 84.44% <0.00%> (+0.72%) 23.00% <0.00%> (+1.00%)
.../java/atas/model/statistics/SessionStatistics.java 96.22% <0.00%> (+3.77%) 23.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae5a09...5c2c969. Read the comment docs.

Copy link

@erisjacey erisjacey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few nitpicks.

docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
Copy link

@nweiyue nweiyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YuunoKun YuunoKun merged commit 6c79f29 into AY2021S1-CS2103T-W16-4:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants