Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UG #158

Merged
merged 6 commits into from
Oct 26, 2020
Merged

Update UG #158

merged 6 commits into from
Oct 26, 2020

Conversation

nweiyue
Copy link

@nweiyue nweiyue commented Oct 26, 2020

No description provided.

Copy link

@erisjacey erisjacey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few nitpicks.

### 5.2 General

[short overview]
This category consists of conventional features (`help`, `exit`, `undo` and `redo` ) that you can find in most applications. It also consists of features that are responsible for navigating through **ATAS** (`switch`) and those that have no specific relation to any of the other categories below(`rng`).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps there could be a space between "below" and the opening paranthesis after it (last few words)?

@@ -578,6 +716,13 @@ Command | Format, Examples

[current session]

{ start of `command_summary#Memo` written by: Ngoh Wei Yue }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Memo could be de-capitalized? Same issue in line 728.

@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #158 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
+ Coverage     75.18%   75.26%   +0.07%     
- Complexity      915      916       +1     
============================================
  Files           131      131              
  Lines          2656     2656              
  Branches        271      271              
============================================
+ Hits           1997     1999       +2     
+ Misses          579      578       -1     
+ Partials         80       79       -1     
Impacted Files Coverage Δ Complexity Δ
.../java/atas/model/statistics/StudentStatistics.java 95.83% <0.00%> (+4.16%) 20.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6ca55b...d5c23e1. Read the comment docs.

@nweiyue nweiyue merged commit e4e5049 into AY2021S1-CS2103T-W16-4:master Oct 26, 2020
@nweiyue nweiyue added this to the v1.3 milestone Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants