-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix first undo empty sessionlist #165
Fix first undo empty sessionlist #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just small nits
@@ -15,6 +15,7 @@ | |||
private final ObservableList<Attributes> currentAttributeList; | |||
private final List<List<Attributes>> attributeStateList; | |||
private int currentStatePointer; | |||
private final List<String> tracker; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a comment could be added to provide a brief description as to what tracker is for? The name isn't as clear atm.
this.currentAttributeList.setAll(attributeList); | ||
if (tracker.isEmpty() || !tracker.get(tracker.size() - 1).equals(name)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a comment could be added here to describe what happens?
No description provided.