Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.4.0 - Fix email and matriculation regex #211

Conversation

marcustw
Copy link

@marcustw marcustw commented Nov 1, 2020

Fix email and matriculation regex, fix documentation bugs

@codecov-io
Copy link

Codecov Report

Merging #211 into master will increase coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #211   +/-   ##
=========================================
  Coverage     74.85%   74.86%           
- Complexity      934      935    +1     
=========================================
  Files           132      132           
  Lines          2760     2761    +1     
  Branches        279      278    -1     
=========================================
+ Hits           2066     2067    +1     
  Misses          604      604           
  Partials         90       90           
Impacted Files Coverage Δ Complexity Δ
.../logic/commands/studentlist/AddStudentCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
src/main/java/atas/model/student/Email.java 80.00% <ø> (ø) 6.00 <0.00> (ø)
src/main/java/atas/logic/parser/AtasParser.java 86.79% <88.57%> (+0.25%) 24.00 <18.00> (+1.00)
...rc/main/java/atas/model/student/Matriculation.java 80.00% <100.00%> (ø) 6.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8449c8...d8fffa9. Read the comment docs.

Copy link

@nweiyue nweiyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/UserGuide.md Outdated Show resolved Hide resolved
@erisjacey erisjacey added this to the v1.4 milestone Nov 1, 2020
@marcustw marcustw merged commit 7da876a into AY2021S1-CS2103T-W16-4:master Nov 1, 2020
@marcustw marcustw linked an issue Nov 1, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment