Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show empty state when not in any session #230

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

nweiyue
Copy link

@nweiyue nweiyue commented Nov 4, 2020

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #230 into master will decrease coverage by 0.29%.
The diff coverage is 6.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #230      +/-   ##
============================================
- Coverage     71.58%   71.28%   -0.30%     
  Complexity      964      964              
============================================
  Files           134      134              
  Lines          2953     2964      +11     
  Branches        307      308       +1     
============================================
- Hits           2114     2113       -1     
- Misses          739      750      +11     
- Partials        100      101       +1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/atas/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ain/java/atas/ui/sessionlist/SessionListPanel.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...i/sessionlist/session/SessionStudentListPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ain/java/atas/ui/studentlist/StudentListPanel.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/main/java/atas/logic/LogicManager.java 83.33% <100.00%> (+0.40%) 12.00 <1.00> (+1.00)
.../java/atas/model/statistics/SessionStatistics.java 92.45% <0.00%> (-3.78%) 22.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379233f...c74afb5. Read the comment docs.

@nweiyue nweiyue added this to the v1.4 milestone Nov 4, 2020
Copy link

@marcustw marcustw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nweiyue nweiyue merged commit 96b51de into AY2021S1-CS2103T-W16-4:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants