Update DG #240
Merged
Update DG #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
============================================
+ Coverage 71.89% 71.96% +0.06%
- Complexity 989 990 +1
============================================
Files 136 136
Lines 3010 3010
Branches 306 306
============================================
+ Hits 2164 2166 +2
+ Misses 754 753 -1
+ Partials 92 91 -1
Continue to review full report at Codecov.
|
erisjacey
approved these changes
Nov 7, 2020
docs/DeveloperGuide.md
Outdated
| 1. This product should be able to function without being connected to a network. | ||
| 1. This product should be able to work without requiring an installer. | ||
| 1. Data generated by the product should be stored locally in human-editable file. | ||
| 1. This product Should not contain very large file sizes (JAR files - 100Mb, PDF files - 15Mb/file). |
There was a problem hiding this comment.
Maybe "Should" should be de-capitalized here?
docs/DeveloperGuide.md
Outdated
Comment on lines
1210
to
1222
| 1. Test case: `addstu n/Alvin Boon m/A0123456X e/alvinboon@u.nus.edu`<br> | ||
| Expected: A student is added to the bottom of the student list. A success message including the particulars of the added student is shown in the result box. | ||
|
|
||
| 1. Test case: `addstu n/Cathy Duigan m/A1123456X e/cathyduigan@u.nus.edu t/helpful`<br> | ||
| Expected: Similar to previous. | ||
|
|
||
| 1. Test case: `addstu m/A2123456X n/Elbert Foo e/elbertfoo@u.nus.edu`<br> | ||
| Expected: Similar to previous. | ||
|
|
||
| 1. Test case: `addstu n/Gina Ho m/A3123456X`<br> | ||
| Expected: No student is added. Error message indicating an invalid command format is shown in the result box. | ||
|
|
||
| 1. Test case: `addstu n/Gina Ho e/ginaho@u.nus.edu`<br> |
There was a problem hiding this comment.
Maybe pictures could be provided for at least one positive test case and one negative test case each?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.