Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug: [Issue #79] Unwanted white box upon full screen #83

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Fix bug: [Issue #79] Unwanted white box upon full screen #83

merged 1 commit into from
Oct 3, 2020

Conversation

nweiyue
Copy link

@nweiyue nweiyue commented Oct 2, 2020

No description provided.

@nweiyue nweiyue self-assigned this Oct 2, 2020
@nweiyue nweiyue added the type.Bug A bug label Oct 2, 2020
@nweiyue nweiyue changed the title Allow tabPane to grow infinitely Fix bug: [Issue #79] Unwanted white box upon full screen Oct 2, 2020
@nweiyue nweiyue removed their assignment Oct 3, 2020
@erisjacey erisjacey linked an issue Oct 3, 2020 that may be closed by this pull request
Ui: Unwanted white box at the bottom of the window when in full-screen mode #79
Closed
erisjacey
erisjacey approved these changes Oct 3, 2020
View reviewed changes
Copy link

@erisjacey erisjacey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marcustw
marcustw approved these changes Oct 3, 2020
View reviewed changes
Copy link

@marcustw marcustw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nweiyue nweiyue merged commit 2aa2ae3 into AY2021S1-CS2103T-W16-4:master Oct 3, 2020
@erisjacey erisjacey added this to the v1.2.1 milestone Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erisjacey erisjacey erisjacey approved these changes

@marcustw marcustw marcustw approved these changes

Assignees
No one assigned
Labels
type.Bug A bug
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging this pull request may close these issues.

Ui: Unwanted white box at the bottom of the window when in full-screen mode
3 participants
@nweiyue @erisjacey @marcustw