Fix bug: [Issue #76] Response message not taking into account quantity of items #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erisjacey
approved these changes
Oct 3, 2020
| if (numberOfStudents == 1) { | ||
| return MESSAGE_SINGLE_STUDENT_LISTED_OVERVIEW; | ||
| } | ||
| return MESSAGE_MULTIPLE_STUDENTS_LISTED_OVERVIEW; |
There was a problem hiding this comment.
Would this make more sense to put in an if-else block (with comments to describe the else block)?
There was a problem hiding this comment.
Right. Thanks for pointing it out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could only find the issue in
findcommand.clearandlistcommand use "all students" so I didn't make any changes to them.