Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor packages #96

Merged
merged 4 commits into from
Oct 10, 2020
Merged

Conversation

erisjacey
Copy link

@erisjacey erisjacey commented Oct 9, 2020

./src/main/java:

  • seedu.address -> atas

  • seedu.address.logic.commands.atascommands
    -> atas.logic.commands.atas

  • seedu.address.logic.commands.confirmationcommands
    -> atas.logic.commands.confirmation

  • seedu.address.logic.commands.sessionlistcommands
    -> atas.logic.commands.sessionlist

  • seedu.address.logic.commands.sessioncommands
    -> atas.logic.commands.sessionlist.session

  • seedu.address.logic.commands.studentlistcommands
    -> atas.logic.commands.studentlist

./src/test/java:

  • seedu.address -> atas

Refactor each Java test file in seedu.address.logic.commands into their own relevant package

  • atas
  • confirmation
  • sessionlist
  • sessionlist.session
  • studentlist

- Comments that seem to be communicating to the developer
@codecov-io
Copy link

codecov-io commented Oct 9, 2020

Codecov Report

Merging #96 into master will increase coverage by 0.29%.
The diff coverage is 78.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #96      +/-   ##
============================================
+ Coverage     70.86%   71.15%   +0.29%     
+ Complexity      651      650       -1     
============================================
  Files           109      109              
  Lines          2073     2063      -10     
  Branches        226      224       -2     
============================================
- Hits           1469     1468       -1     
+ Misses          537      528       -9     
  Partials         67       67              
Impacted Files Coverage Δ Complexity Δ
src/main/java/atas/Main.java 0.00% <ø> (ø) 0.00 <0.00> (?)
src/main/java/atas/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/atas/commons/core/Config.java 68.18% <ø> (ø) 7.00 <0.00> (?)
src/main/java/atas/commons/core/GuiSettings.java 69.23% <ø> (ø) 5.00 <0.00> (?)
src/main/java/atas/commons/core/LogsCenter.java 78.37% <ø> (ø) 10.00 <0.00> (?)
src/main/java/atas/commons/core/Messages.java 75.00% <ø> (ø) 2.00 <0.00> (?)
src/main/java/atas/commons/core/Version.java 82.50% <ø> (ø) 19.00 <0.00> (?)
src/main/java/atas/commons/core/index/Index.java 75.00% <ø> (ø) 11.00 <0.00> (?)
...as/commons/exceptions/DataConversionException.java 100.00% <ø> (ø) 1.00 <0.00> (?)
...atas/commons/exceptions/IllegalValueException.java 100.00% <ø> (ø) 2.00 <0.00> (?)
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719cce3...da3ac78. Read the comment docs.

./src/main/java:

- atas.logic.commands.atascommands
    -> atas.commons.logic.commands.atas
- atas.logic.commands.confirmationcommands
    -> atas.commons.logic.commands.confirmation
- atas.logic.commands.sessionlistcommands
    -> atas.commons.logic.commands.sessions
- atas.logic.commands.sessioncommands
    -> atas.commons.logic.commands.sessions.session
- atas.logic.commands.studentlistcommands
    -> atas.commons.logic.commands.students

./src/test/java:

Refactor each Java test file in commands into their own relevant package
- atas
- confirmation
- sessions
- sessions.session
- students
From: atas.logic.commands.atas
To: atas.logic.commands.studentlist

- FindCommand
- ListCommand
Copy link

@nweiyue nweiyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nweiyue nweiyue merged commit b6c7668 into AY2021S1-CS2103T-W16-4:master Oct 10, 2020
@erisjacey erisjacey added this to the v1.2.1 milestone Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants