Refactor class names #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
=========================================
Coverage 75.95% 75.95%
Complexity 719 719
=========================================
Files 109 109
Lines 2071 2071
Branches 225 225
=========================================
Hits 1573 1573
Misses 444 444
Partials 54 54
Continue to review full report at Codecov.
|
…-names # Conflicts: # src/main/java/atas/model/attendance/Session.java
nweiyue
approved these changes
Oct 12, 2020
docs/DeveloperGuide.md
Outdated
| @@ -25,7 +25,7 @@ title: Developer Guide | |||
| * [Glossary](#glossary) | |||
| * [**Appendix: Instructions for manual testing**](#appendix_manual_testing) | |||
| * [Launch and shutdown](#launch_shutdown) | |||
| * [Deleting a person](#deleting_a_person) | |||
| * [Deleting a student](#deleting_a_studentn) | |||
There was a problem hiding this comment.
Should "studentn" be "student instead?
| @@ -5,7 +5,7 @@ title: "Tutorial: Adding a command" | |||
|
|
|||
| Let's walk you through the implementation of a new command — `remark`. | |||
|
|
|||
| This command allows users of the AddressBook application to add optional remarks to people in their address book and edit it if required. The command should have the following format: | |||
| This command allows users of the StudentList application to add optional remarks to people in their student list and edit it if required. The command should have the following format: | |||
docs/tutorials/AddRemark.md
Outdated
| model.setPerson(personToEdit, editedPerson); | ||
| model.updateFilteredPersonList(PREDICATE_SHOW_ALL_PERSONS); | ||
| model.setStudent(studentToEdit, editedStudent); | ||
| model.updateFilteredStudentList(PREDICATE_SHOW_ALL_PERSONS); |
There was a problem hiding this comment.
Should the constant messages be renamed as well? I've noticed this issue in other places as well.
…ass-names # Conflicts: # src/test/java/atas/logic/commands/sessionlist/EditSessionCommandTest.java # src/test/java/atas/logic/commands/sessionlist/session/ParticipateCommandTest.java # src/test/java/atas/logic/commands/sessionlist/session/PresenceCommandTest.java # src/test/java/atas/logic/commands/studentlist/DeleteSessionCommandTest.java # src/test/java/atas/logic/parser/AtasParserTest.java # src/test/java/atas/logic/parser/ParserUtilTest.java
erisjacey
reviewed
Oct 13, 2020
| @@ -19,7 +19,7 @@ activate model MODEL_COLOR | |||
| model -[MODEL_COLOR]-> logic | |||
| deactivate model | |||
|
|
|||
| logic -[LOGIC_COLOR]> storage : saveAddressBook(addressBook) | |||
| logic -[LOGIC_COLOR]> storage : saveAddressBook(studentList) | |||
There was a problem hiding this comment.
Should this be something like saveStudentList?
| @@ -180,7 +180,7 @@ Recall from the User Guide that the `edit` command has the format: `edit INDEX [ | |||
| * {@code JsonSerializableAddressBook}. | |||
| */ | |||
| public JsonSerializableAddressBook(ReadOnlyAddressBook source) { | |||
There was a problem hiding this comment.
Maybe change this to JsonSerializableStudentList and correspondingly ReadOnlyStudentList?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor class names