Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UG in save feature & Update PPP #282

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Update UG in save feature & Update PPP #282

merged 2 commits into from
Nov 9, 2020

Conversation

PhongTran98
Copy link

No description provided.

@PhongTran98 PhongTran98 added the type.Documentation Improvements or additions to documentation (e.g. README.md, User Guide, etc.) label Nov 9, 2020
@PhongTran98 PhongTran98 added this to the v1.4 milestone Nov 9, 2020
@PhongTran98 PhongTran98 self-assigned this Nov 9, 2020
@codecov-io
Copy link

codecov-io commented Nov 9, 2020 •
edited

Codecov Report

Merging #282 (df68773) into master (23d212d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #282   +/-   ##
=========================================
  Coverage     72.04%   72.04%           
  Complexity      633      633           
=========================================
  Files            91       91           
  Lines          1914     1914           
  Branches        227      227           
=========================================
  Hits           1379     1379           
  Misses          456      456           
  Partials         79       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d212d...df68773. Read the comment docs.

@PhongTran98 PhongTran98 changed the title Update UG in save feature Update UG in save feature & Update PPP Nov 9, 2020
duynguyen24501
duynguyen24501 approved these changes Nov 9, 2020
View reviewed changes
Copy link

@duynguyen24501 duynguyen24501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duynguyen24501 duynguyen24501 merged commit 1321f2d into AY2021S1-CS2103T-W17-1:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duynguyen24501 duynguyen24501 duynguyen24501 approved these changes

Assignees

@PhongTran98 PhongTran98

Labels
type.Documentation Improvements or additions to documentation (e.g. README.md, User Guide, etc.)
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PhongTran98 @codecov-io @duynguyen24501