Storage v1

[Nahoyhp]

Read, Write and Archive for ExerciseBook is completed.

[leeweiminsg]

Tested locally, default test cases passed.

Issue when running TestDriver.java locally:

12:14:17 PM: Executing task 'TestDriver.main()'...

Task :compileJava UP-TO-DATE
Task :processResources UP-TO-DATE
Task :classes UP-TO-DATE

Task :TestDriver.main()
Exceptions

BUILD SUCCESSFUL in 0s
3 actionable tasks: 1 executed, 2 up-to-date
Oct 07, 2020 12:14:18 PM seedu.address.commons.util.JsonUtil readJsonFile
INFO: Json file data\testing.json not found
12:14:18 PM: Task execution finished 'TestDriver.main()'.

Data stored in the /data/ won't be included in commit (listed in gitignore).

Perhaps you can move them to src/test/data instead?
Also, I think the TestDriver class should belong somewhere in src/test instead. Classes in src/main are used in running the app itself.

[Nahoyhp]

This is not my final copy yet. Just want to run the above tests to see where I need to help.

[codecov-io]

Codecov Report

Merging #24 into v1.2 will decrease coverage by 8.90%.
The diff coverage is 32.77%.

@@             Coverage Diff              @@
##               v1.2      #24      +/-   ##
============================================
- Coverage     72.31%   63.40%   -8.91%     
- Complexity      400      451      +51     
============================================
  Files            70       90      +20     
  Lines          1228     1585     +357     
  Branches        124      156      +32     
============================================
+ Hits            888     1005     +117     
- Misses          308      538     +230     
- Partials         32       42      +10     

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/seedu/address/TestDriver.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...a/seedu/address/logic/LogicManagerForExercise.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...a/seedu/address/logic/commands/ArchiveCommand.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...edu/address/logic/commands/CommandForExercise.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...edu/address/logic/parser/ArchiveCommandParser.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...seedu/address/logic/parser/ExerciseBookParser.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...in/java/seedu/address/logic/parser/ParserUtil.java	76.08% <0.00%> (-21.14%)	14.00 <0.00> (ø)
...c/main/java/seedu/address/model/ExerciseModel.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...ain/java/seedu/address/model/ModelForExercise.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...va/seedu/address/storage/JsonUserPrefsStorage.java	63.63% <0.00%> (-23.87%)	4.00 <0.00> (ø)
... and 34 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8a6f84...b5cb56d. Read the comment docs.

[Liu-2001]

Tested locally. All storage related tests passed.

For TestDriver.java, if I run it multiple times, the data will be stored repeatedly into testingForExercise.json. Is that the desired outcome or should you first clear the file and then store the exercise book? (not sure about this)

Otherwise LGTM.

[Nahoyhp]

The TestDriver is created to ensure that I can read and write from the data.
The reason for the repeats is because it reads all the items in the storage, can't realize that items with same name and date are the same (cuz i am using stubs) and just add items at the end of the list.
The TestDriver also includes reading from past records and add the same set of Exercise at the end.