Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/update command parser #41

Merged

Conversation

leeweiminsg
Copy link

  • Fixed bugs
  • Added weak equality checks
  • Add test cases for update exercise parser

@leeweiminsg leeweiminsg linked an issue Oct 17, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #41 into v1.2 will increase coverage by 0.59%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               v1.2      #41      +/-   ##
============================================
+ Coverage     58.48%   59.07%   +0.59%     
+ Complexity      506      505       -1     
============================================
  Files           100      100              
  Lines          1932     1933       +1     
  Branches        197      197              
============================================
+ Hits           1130     1142      +12     
+ Misses          723      705      -18     
- Partials         79       86       +7     
Impacted Files Coverage Δ Complexity Δ
...java/seedu/address/model/exercise/Description.java 70.00% <100.00%> (+3.33%) 6.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 50.00% <0.00%> (-42.31%) 3.00% <0.00%> (-8.00%)
.../address/logic/commands/UpdateExerciseCommand.java 85.71% <0.00%> (+1.58%) 12.00% <0.00%> (ø%)
...ress/logic/parser/UpdateExerciseCommandParser.java 100.00% <0.00%> (+100.00%) 7.00% <0.00%> (+7.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51b4afa...13160a8. Read the comment docs.

@leeweiminsg leeweiminsg changed the base branch from v1.2 to v1.3 October 19, 2020 09:26
@Nahoyhp
Copy link

Nahoyhp commented Oct 19, 2020

No problem found.

@Nauman-S
Copy link

Good use of comments

@Nauman-S Nauman-S merged commit 7567031 into AY2021S1-CS2103T-W17-2:v1.3 Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement parser tests
4 participants