Add template command and template creation #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeweiminsg
reviewed
Oct 26, 2020
|
|
||
| public class AddTemplateCommand extends CommandForExercise{ | ||
|
|
||
| public static final String COMMAND_WORD = "temp"; |
There was a problem hiding this comment.
maybe better command word? Since temp can mean temporary
leeweiminsg
reviewed
Oct 26, 2020
|
|
||
| private final Exercise toAdd; | ||
|
|
||
| public AddTemplateCommand(Exercise toAdd) { |
There was a problem hiding this comment.
Naming with CreateTemplateCommand is similar
leeweiminsg
reviewed
Oct 26, 2020
| ArgumentTokenizer.tokenize(args, PREFIX_NAME, PREFIX_DESCRIPTION, PREFIX_CALORIES); | ||
|
|
||
| if (!arePrefixesPresent(argMultimap, PREFIX_NAME, PREFIX_DESCRIPTION, PREFIX_CALORIES) | ||
| /*|| !argMultimap.getPreamble().isEmpty()*/) { |
leeweiminsg
reviewed
Oct 26, 2020
| @@ -105,6 +107,12 @@ public void addExercise(Exercise exercise) { | |||
| updateFilteredExerciseList(PREDICATE_SHOW_ALL_EXERCISE); | |||
| } | |||
|
|
|||
| @Override | |||
| public void createTemplate(Template template) { | |||
There was a problem hiding this comment.
createtemplate vs addtemplate: same idea, different naming? Better to use one
Nahoyhp
reviewed
Oct 26, 2020
There was a problem hiding this comment.
Suggestions for future implementation:
- Create JSonTemplate class to write the file in JsonFormat
- Abstract out the load (which is now at TemplateList) and write (which is now at Template) to Storage class.
For now, it is fine. Best to implement for the next iteration.
| return list; | ||
| } | ||
|
|
||
| public static Template getTemp(String name) { |
| FileWriter fw = new FileWriter("data/template.txt"); | ||
| String textToAdd = ""; | ||
|
|
||
| for (int i = 0; i < lists.size(); i++) { |
There was a problem hiding this comment.
Better to extract this and add it to storage
…nto v1.3 # Conflicts: # src/main/java/seedu/address/logic/parser/AddCommandParser.java
Codecov Report
@@ Coverage Diff @@
## v1.3 #62 +/- ##
============================================
- Coverage 60.68% 56.89% -3.79%
Complexity 518 518
============================================
Files 100 106 +6
Lines 1928 2058 +130
Branches 197 213 +16
============================================
+ Hits 1170 1171 +1
- Misses 672 800 +128
- Partials 86 87 +1
Continue to review full report at Codecov.
|
This was
linked to
issues
Oct 26, 2020
This was referenced Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.