forked from nus-cs2103-AY2021S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add muscle class (parsing, read/write, tests) (3/3) #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From person to exercise
From persons to exercises
Closed
Codecov Report
@@ Coverage Diff @@
## v1.3 #72 +/- ##
============================================
- Coverage 60.68% 59.36% -1.33%
- Complexity 518 571 +53
============================================
Files 100 111 +11
Lines 1928 2254 +326
Branches 197 249 +52
============================================
+ Hits 1170 1338 +168
- Misses 672 825 +153
- Partials 86 91 +5
Continue to review full report at Codecov.
|
leeweiminsg
changed the title
Add muscle class (read/write, tests) (1/2)
Add muscle class (parsing, read/write, tests) (1/2)
Oct 27, 2020
leeweiminsg
changed the title
Add muscle class (parsing, read/write, tests) (1/2)
Add muscle class (parsing, read/write, tests) (2/3)
Oct 27, 2020
leeweiminsg
changed the title
Add muscle class (parsing, read/write, tests) (2/3)
Add muscle class (parsing, read/write, tests) (3/3)
Oct 27, 2020
This was
linked to
issues
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added musclesWorked variable in Exercise class
Made calories optional (as stated in user guide). Removed calories in equality checking (enforce functional dependency: name->calories)
Fixed several formatting errors in previous commits
Added parsing support (add, update)
Modified test cases to support musclesWorked, added previously commented-out ones
Added UI support
Some issues with storage and UI: will add to issues