Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add muscle class (parsing, read/write, tests) (3/3) #72

Merged
merged 9 commits into from
Oct 28, 2020

Conversation

leeweiminsg
Copy link

@leeweiminsg leeweiminsg commented Oct 27, 2020

  • Added musclesWorked variable in Exercise class

  • Made calories optional (as stated in user guide). Removed calories in equality checking (enforce functional dependency: name->calories)

  • Fixed several formatting errors in previous commits

  • Added parsing support (add, update)

  • Modified test cases to support musclesWorked, added previously commented-out ones

  • Added UI support

  • Some issues with storage and UI: will add to issues

@leeweiminsg leeweiminsg added this to the v1.3 milestone Oct 27, 2020
@leeweiminsg leeweiminsg linked an issue Oct 27, 2020 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Oct 27, 2020

Codecov Report

Merging #72 into v1.3 will decrease coverage by 1.32%.
The diff coverage is 39.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##               v1.3      #72      +/-   ##
============================================
- Coverage     60.68%   59.36%   -1.33%     
- Complexity      518      571      +53     
============================================
  Files           100      111      +11     
  Lines          1928     2254     +326     
  Branches        197      249      +52     
============================================
+ Hits           1170     1338     +168     
- Misses          672      825     +153     
- Partials         86       91       +5     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/TestDriver.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/seedu/address/logic/LogicManagerForExercise.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/seedu/address/logic/commands/AddCommand.java 83.33% <ø> (ø) 7.00 <0.00> (ø)
...ddress/logic/commands/AddExerciseFromTemplate.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...edu/address/logic/commands/AddTemplateCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...edu/address/logic/commands/CommandForExercise.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...va/seedu/address/logic/commands/CommandResult.java 88.23% <ø> (ø) 10.00 <0.00> (ø)
...va/seedu/address/logic/commands/RecallCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ss/logic/parser/AddExerciseFromTemplateParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...address/logic/parser/AddTemplateCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e6f99...c6af2f6. Read the comment docs.

@leeweiminsg leeweiminsg changed the title Add muscle class (read/write, tests) (1/2) Add muscle class (parsing, read/write, tests) (1/2) Oct 27, 2020
@leeweiminsg leeweiminsg changed the title Add muscle class (parsing, read/write, tests) (1/2) Add muscle class (parsing, read/write, tests) (2/3) Oct 27, 2020
@leeweiminsg leeweiminsg changed the title Add muscle class (parsing, read/write, tests) (2/3) Add muscle class (parsing, read/write, tests) (3/3) Oct 27, 2020
This was linked to issues Oct 27, 2020
@leeweiminsg leeweiminsg merged commit aba2f6d into AY2021S1-CS2103T-W17-2:v1.3 Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exercise card not displaying exerciseBookReadSave test case failing Create muscle class
2 participants