Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logic writeup #101

Merged
merged 10 commits into from
Oct 21, 2020
Merged

Update logic writeup #101

merged 10 commits into from
Oct 21, 2020

Conversation

JoeyChenSmart
Copy link

@JoeyChenSmart JoeyChenSmart commented Oct 20, 2020 •
edited

What I've done in this PR

  • Change the writeup on logic component
  • Added a link to the PR for more details on the new logic architecture.
  • Replace diagrams in logic (1 class diagram + 1 sequence diagram)
  • Made a short writeup on macros
  • Add class and sequence diagram for macros

@codecov-io
Copy link

codecov-io commented Oct 20, 2020 •
edited

Codecov Report

Merging #101 into master will increase coverage by 1.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #101      +/-   ##
============================================
+ Coverage     72.31%   73.35%   +1.04%     
- Complexity      400      472      +72     
============================================
  Files            70       79       +9     
  Lines          1228     1535     +307     
  Branches        124      123       -1     
============================================
+ Hits            888     1126     +238     
- Misses          308      365      +57     
- Partials         32       44      +12
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/AddCommand.java
...rc/main/java/seedu/address/model/ModelManager.java
...n/java/seedu/address/commons/core/index/Index.java
...java/seedu/address/logic/commands/ExitCommand.java
.../main/java/seedu/address/commons/util/AppUtil.java
.../java/seedu/address/model/util/SampleDataUtil.java
...c/main/java/seedu/address/logic/parser/Prefix.java
...a/seedu/address/logic/parser/AddCommandParser.java
...va/seedu/address/logic/commands/CommandResult.java
...va/seedu/address/logic/commands/DeleteCommand.java
... and 139 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8066e1...209c017. Read the comment docs.

@Jh123x Jh123x added the documentation Improvements or additions to documentation label Oct 20, 2020
@Jh123x Jh123x added this to the v1.3 milestone Oct 20, 2020
@Jh123x Jh123x linked an issue Oct 20, 2020 that may be closed by this pull request
Update UML Diagrams in DG to reflect accurate flow of diagram #34
Closed
11 tasks
@JoeyChenSmart JoeyChenSmart changed the title [WIP] Update logic writeup Update logic writeup Oct 20, 2020
@JoeyChenSmart JoeyChenSmart marked this pull request as ready for review October 20, 2020 12:36
chewypiano
chewypiano reviewed Oct 21, 2020
View reviewed changes
Copy link

@chewypiano chewypiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, just the most minor nits.

docs/diagrams/DeleteSequenceDiagram.puml Outdated
Comment on lines 33 to 35

PrimitiveCommandParser --> DeleteCommand : getParameterSet
activate DeleteCommand
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be -> instead of --> ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup you're probably right. I mustve copy pasted wrongly somewhere

docs/diagrams/DeleteSequenceDiagram.puml Outdated
Comment on lines 40 to 42

PrimitiveCommandParser --> PrimitiveCommandParser : provideValuesToParameterSet
activate PrimitiveCommandParser
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to previous comment, shouldn't this be -> instead of -->?

chewypiano
chewypiano approved these changes Oct 21, 2020
View reviewed changes
Copy link

@chewypiano chewypiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chewypiano chewypiano merged commit 53ed1f9 into AY2021S1-CS2103T-W17-3:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chewypiano chewypiano chewypiano approved these changes

Assignees

@JoeyChenSmart JoeyChenSmart

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Update UML Diagrams in DG to reflect accurate flow of diagram
4 participants
@JoeyChenSmart @codecov-io @chewypiano @Jh123x