Fix 215

[Jh123x]

Closes #215

• Update getMessageConstraint as abstract
• Standardise Variable names
• Move MESSAGE_INVALID_INDEX into Index instead of ParserUtil

[JoeyChenSmart]

I was thinking more in the line of "the two methods should point to the same string" rather than "the two different strings should have the same content", but that might take a bit of work.

Also related PR #208 not sure if theres overlaps?

[codecov-io]

Codecov Report

Merging #219 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #219      +/-   ##
============================================
+ Coverage     71.07%   71.10%   +0.03%     
- Complexity      552      554       +2     
============================================
  Files            87       87              
  Lines          1884     1886       +2     
  Branches        151      151              
============================================
+ Hits           1339     1341       +2     
  Misses          486      486              
  Partials         59       59              

Impacted Files	Coverage Δ	Complexity Δ
...n/java/jimmy/mcgymmy/commons/core/index/Index.java	100.00% <ø> (ø)	10.00 <0.00> (ø)
...n/java/jimmy/mcgymmy/model/food/Macronutrient.java	86.95% <ø> (-0.55%)	17.00 <0.00> (-1.00)
...in/java/jimmy/mcgymmy/logic/parser/ParserUtil.java	69.13% <100.00%> (ø)	15.00 <0.00> (ø)
...in/java/jimmy/mcgymmy/model/food/Carbohydrate.java	50.00% <100.00%> (+7.14%)	4.00 <1.00> (+1.00)
src/main/java/jimmy/mcgymmy/model/food/Fat.java	50.00% <100.00%> (+7.14%)	4.00 <1.00> (+1.00)
...rc/main/java/jimmy/mcgymmy/model/food/Protein.java	50.00% <100.00%> (+7.14%)	4.00 <2.00> (+1.00)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a6fcd2...dbad0ca. Read the comment docs.

[Jh123x]

I was thinking more in the line of "the two methods should point to the same string" rather than "the two different strings should have the same content", but that might take a bit of work.

Also related PR #208 not sure if theres overlaps?

Yeap i think it overlaps x.x

[aidoxe-123]

I think the old implementation of getMessageConstraint is better than this one. I have given more details about why I think so in one of the comments

[aidoxe-123]

I think we should move "amount can only ..." outside to be a string called MESSAGE_CONSTRAINT_SUFFIX. The old implementation works just as fine as the new one. The old one even has fewer repeated code. So why do we need to change?

[Jh123x]

It is to make sure all of them point to the same message so that the messages shown will be consistent everywhere

[aidoxe-123]

The old one also makes sure all of them point to the same message, isn't it

[aidoxe-123]

LGTM