Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for find and clear #229

Merged
merged 5 commits into from
Nov 4, 2020
Merged

Conversation

dcchan98
Copy link

@dcchan98 dcchan98 commented Nov 4, 2020

No description provided.

}

@Test
public void fnd_empty_mcGymmyHasCorrectContent() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a typo here and in the test method names below; should be find_empty.... instead of fnd_.... Just a minor nit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

@codecov-io
Copy link

Codecov Report

Merging #229 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #229   +/-   ##
=========================================
  Coverage     71.07%   71.07%           
  Complexity      552      552           
=========================================
  Files            87       87           
  Lines          1884     1884           
  Branches        151      151           
=========================================
  Hits           1339     1339           
  Misses          486      486           
  Partials         59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0949115...0ee6530. Read the comment docs.

@Jh123x Jh123x added this to the v1.4 milestone Nov 4, 2020
@Jh123x Jh123x added the type.Enhancement New feature or request (!DELETE ME IF DASHBOARD IS NOT UPDATING) label Nov 4, 2020
Copy link

@Jh123x Jh123x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jh123x Jh123x merged commit 19841f9 into AY2021S1-CS2103T-W17-3:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Enhancement New feature or request (!DELETE ME IF DASHBOARD IS NOT UPDATING)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants