Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for AddCommand #70

Merged
merged 4 commits into from
Oct 12, 2020

Conversation

aidoxe-123
Copy link

Improve test coverage

@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #70 into master will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
+ Coverage     72.58%   72.80%   +0.21%     
- Complexity      415      416       +1     
============================================
  Files            73       73              
  Lines          1375     1375              
  Branches        107      107              
============================================
+ Hits            998     1001       +3     
+ Misses          337      335       -2     
+ Partials         40       39       -1     
Impacted Files Coverage Δ Complexity Δ
.../java/jimmy/mcgymmy/logic/commands/AddCommand.java 100.00% <0.00%> (+13.04%) 4.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cdd4de...1a205ab. Read the comment docs.

@aidoxe-123 aidoxe-123 added this to the v1.2b milestone Oct 11, 2020
Copy link

@Jh123x Jh123x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Just need to resolve the conflict

Copy link

@Jh123x Jh123x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jh123x Jh123x merged commit 50f7c42 into AY2021S1-CS2103T-W17-3:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants