Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Import Command #87

Merged
merged 13 commits into from
Oct 19, 2020

Conversation

Jh123x
Copy link

@Jh123x Jh123x commented Oct 17, 2020

#86 Add Import Command

Format: import filepath where filepath is the path to the file

Todo

  • Add import command
  • Add test cases

@Jh123x Jh123x added the type.Enhancement New feature or request (!DELETE ME IF DASHBOARD IS NOT UPDATING) label Oct 17, 2020
@Jh123x Jh123x added this to the v1.3 milestone Oct 17, 2020
@Jh123x Jh123x self-assigned this Oct 17, 2020
@Jh123x Jh123x linked an issue Oct 17, 2020 that may be closed by this pull request
@Jh123x Jh123x marked this pull request as draft October 17, 2020 00:08
@codecov-io
Copy link

Codecov Report

Merging #87 into master will decrease coverage by 0.66%.
The diff coverage is 17.64%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #87      +/-   ##
============================================
- Coverage     73.21%   72.54%   -0.67%     
- Complexity      425      426       +1     
============================================
  Files            73       74       +1     
  Lines          1400     1417      +17     
  Branches        110      111       +1     
============================================
+ Hits           1025     1028       +3     
- Misses          335      349      +14     
  Partials         40       40              
Impacted Files Coverage Δ Complexity Δ
...in/java/jimmy/mcgymmy/logic/parser/ParserUtil.java 89.28% <0.00%> (-5.06%) 13.00 <0.00> (ø)
...va/jimmy/mcgymmy/logic/commands/ImportCommand.java 15.38% <15.38%> (ø) 1.00 <1.00> (?)
...y/mcgymmy/logic/parser/PrimitiveCommandParser.java 93.93% <100.00%> (+0.09%) 19.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 133bfdc...e36ad28. Read the comment docs.

@Jh123x Jh123x marked this pull request as ready for review October 19, 2020 07:12
Copy link

@chewypiano chewypiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chewypiano chewypiano merged commit 9da8445 into AY2021S1-CS2103T-W17-3:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Enhancement New feature or request (!DELETE ME IF DASHBOARD IS NOT UPDATING)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Import Command
3 participants