-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add undo command #97
Add undo command #97
Conversation
# Conflicts: # src/main/java/jimmy/mcgymmy/logic/parser/PrimitiveCommandParser.java
Only edit food when the editedFood is different from the original
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
============================================
+ Coverage 73.10% 73.45% +0.34%
- Complexity 463 472 +9
============================================
Files 78 79 +1
Lines 1517 1533 +16
Branches 122 122
============================================
+ Hits 1109 1126 +17
Misses 365 365
+ Partials 43 42 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Might be good to add more assertions for v1.3
src/test/java/jimmy/mcgymmy/logic/commands/UndoCommandTest.java
Outdated
Show resolved
Hide resolved
This property is used in execute_canUndo_success test case
Add an undo command that undoes the previous change to the list.
I think saving the state of the food list only when there is a change is more reasonable because if we save the state whenever a command is called, the app will look like it doesn't react if the user types in a lot of
list
commands, followed by a list ofundo
commandsAdd test cases for this feature
close #74