Supports creating and deleting of multiple tags within one user input #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated CreateTagCommand and DeleteTagCommand to support creating and deleting of multiple tags within 1 instruction. Added new enum to SystemException to handle more specific missing information. Restructured the handling of exception in the prepare functions to return SystemException and catch them within the parseCommand function.
R-Ramana
requested changes
Oct 8, 2020
| private int index; | ||
| private String tagName; | ||
| private String tagColor; | ||
| private final int index; |
There was a problem hiding this comment.
Private final right, so should be all CAPS? Can just commit directly from my suggestion :D
Suggested change
| private final int index; | |
| private final int INDEX; |
There was a problem hiding this comment.
The intellji gave warning saying that the field may be final so I changed it. Will be reverting that since the int cannot be final. Likewise for the rest of the similar cases below
| private String tagName; | ||
| private String tagColor; | ||
| private final int index; | ||
| private final ArrayList<Tag> tags; |
There was a problem hiding this comment.
Same as above
Suggested change
| private final ArrayList<Tag> tags; | |
| private final ArrayList<Tag> TAGS; |
| private static final String STRING_TAG_EMPTY = "There are no tags!"; | ||
| private static final String STRING_TAG_LIST = "Here are the available tags:" + InterfaceManager.LS; | ||
|
|
||
| private final Map<Tag, ArrayList<Note>> tagMap; |
There was a problem hiding this comment.
Should it be TAGMAP?
Suggested change
| private final Map<Tag, ArrayList<Note>> tagMap; | |
| private final Map<Tag, ArrayList<Note>> TAGMAP; |
Co-authored-by: R Ramana <54029207+R-Ramana@users.noreply.github.com>
… into JunXiang-branch-TagNote # Conflicts: # src/main/java/seedu/duke/data/notebook/Tag.java
# Conflicts: # src/main/java/seedu/duke/data/notebook/TagManager.java # src/main/java/seedu/duke/util/Parser.java # text-ui-test/EXPECTED.TXT Did some clean up of the code. Added more SystemException. Modified some of the prepare functions in parser to throw SystemException.
R-Ramana
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Refactored prepareCreateTag and prepareDeleteTag into one function
*Created function to process TAG message
*Added more SystemException for specific missing information
*Modified the prepare functions to throw a SystemException, which is to be catched in the parseCommand function for the various missing information
*Included JColor library to support printing colored fonts
Closes #26
Closes #19