Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package name #33

Merged
merged 8 commits into from Oct 7, 2020

Conversation

Zhi-You
Copy link

@Zhi-You Zhi-You commented Oct 7, 2020

Fixes #30. This change will help personalize our project.

Copy link

@josephhhhhhhhh josephhhhhhhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure the build.gradle has the updated package names as well.

@kstonekuan kstonekuan added the priority.Medium Nice to have label Oct 7, 2020
@kstonekuan kstonekuan added this to the v1.0 milestone Oct 7, 2020
Resolved conflicts

# Conflicts:
#	src/main/java/seedu/duke/OptionInterface.java
#	src/main/java/seedu/duke/OptionListInterface.java
#	src/main/java/seedu/eduke8/OptionInterface.java
#	src/main/java/seedu/eduke8/OptionListInterface.java
#	src/main/java/seedu/eduke8/UiInterface.java
#	src/main/java/seedu/eduke8/option/Option.java
#	src/main/java/seedu/eduke8/option/OptionInterface.java
#	src/main/java/seedu/eduke8/option/OptionList.java
#	src/main/java/seedu/eduke8/option/OptionListInterface.java
#	src/main/java/seedu/eduke8/question/Question.java
#	src/main/java/seedu/eduke8/question/QuestionInterface.java
#	src/main/java/seedu/eduke8/storage/Storage.java
Resolved merge conflicts

# Conflicts:
#	src/main/java/seedu/duke/UiInterface.java
#	src/main/java/seedu/eduke8/UiInterface.java
#	src/main/java/seedu/eduke8/storage/Storage.java
#	src/main/java/seedu/eduke8/ui/Ui.java
#	src/main/java/seedu/eduke8/ui/UiInterface.java
Copy link

@anqi20 anqi20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome personalisation!

@anqi20 anqi20 dismissed josephhhhhhhhh’s stale review October 7, 2020 07:04

It has been changed already.

@anqi20 anqi20 merged commit 3d19330 into AY2021S1-CS2113T-F12-3:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change packages name to eduke8
4 participants