Enhance ui to improve user experience #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhi-You
added
type.Enhancement
kstonekuan
approved these changes
Oct 15, 2020
| These are the available topics: | ||
| OOP | ||
| These are the available topics and the number of available questions in each: | ||
| OOP [1] |
There was a problem hiding this comment.
Cool idea to add the number of questions
Comment on lines
+74
to
+95
| The number of quiz questions must be more than 1! | ||
| ------------------------------------------------------------------- | ||
| ------------------------------------------------------------------- | ||
| There is not enough questions in the topic for the quiz! | ||
| ------------------------------------------------------------------- | ||
| ------------------------------------------------------------------- | ||
| Start of quiz: | ||
| You have chosen to complete 1 question. | ||
| The topic chosen is: OOP | ||
| ------------------------------------------------------------------- | ||
| 1. What is encapsulation? | ||
|
|
||
| 1) A | ||
| 2) B | ||
| 3) C | ||
| 4) D | ||
| ------------------------------------------------------------------- | ||
| ------------------------------------------------------------------- | ||
| Please choose the answer using its index (1,2,3 or 4)! | ||
| ------------------------------------------------------------------- | ||
| ------------------------------------------------------------------- | ||
| Please choose only options 1, 2, 3 or 4 |
There was a problem hiding this comment.
Nice, good to check our exceptions
josephhhhhhhhh
approved these changes
Oct 15, 2020
anqi20
approved these changes
Oct 15, 2020
| + System.lineSeparator() | ||
| + "quiz t/<topic> n/<number of questions>"; | ||
| + System.lineSeparator() + "quiz t/<topic> n/<number of questions>" + System.lineSeparator() | ||
| + "(Topics available can be found using the \"topics\" command)"; |
There was a problem hiding this comment.
Oh thank you for adjusting the formatting!
Comment on lines
-47
to
+50
| return new IncorrectCommand("Please choose only 1, 2, 3 or 4"); | ||
| return new IncorrectCommand(ERROR_QUIZ_ANSWER_INDEX_OUT_OF_BOUNDS); |
Comment on lines
-42
to
+43
| private static final String MESSAGE_ANSWER_CORRECT = "Congrats! This answer is correct! Well Done!"; | ||
| private static final String MESSAGE_ANSWER_CORRECT = "Great Job! That is the correct answer! Keep it up!"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89