Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Appointment Filter feature (Complete) #165

Merged

Conversation

kingsleykuan
Copy link

Adds Appointment Filter feature with add_appointment_filter and delete_appointment_filter commands.

Only merge after PR #158 is merged.

@codecov-io
Copy link

Codecov Report

Merging #165 (a91c167) into master (3dc6c8e) will decrease coverage by 1.80%.
The diff coverage is 34.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #165      +/-   ##
============================================
- Coverage     47.30%   45.49%   -1.81%     
- Complexity      665      684      +19     
============================================
  Files           173      188      +15     
  Lines          3355     3853     +498     
  Branches        392      478      +86     
============================================
+ Hits           1587     1753     +166     
- Misses         1655     1957     +302     
- Partials        113      143      +30     
Impacted Files Coverage Δ Complexity Δ
...ds/filtercommands/AddAppointmentFilterCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...filtercommands/DeleteAppointmentFilterCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...seedu/address/logic/parser/TutorTrackerParser.java 37.50% <0.00%> (-1.98%) 11.00 <0.00> (ø)
...ilterparser/AddAppointmentFilterCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...erparser/DeleteAppointmentFilterCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...java/seedu/address/model/filter/AddressFilter.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ddress/model/filter/AppointmentDateTimeFilter.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...n/java/seedu/address/model/filter/EmailFilter.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../java/seedu/address/model/filter/GenderFilter.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dc6c8e...a91c167. Read the comment docs.

@kingsleykuan kingsleykuan changed the title Add Appointment Filter feature (Merge after previous PR) Add Appointment Filter feature (Complete) Mar 29, 2021
Copy link

@jared98lyj jared98lyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@glatiuden glatiuden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kingsleykuan kingsleykuan merged commit 984f074 into AY2021S2-CS2103-T14-3:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants