Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertion to remark constructor #108

Conversation

oeiyiping
Copy link

@oeiyiping oeiyiping commented Mar 24, 2021

For partial completion of #110

@oeiyiping oeiyiping added this to the v1.3 milestone Mar 24, 2021
@oeiyiping oeiyiping self-assigned this Mar 24, 2021
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #108 (6f79eb7) into master (975ec8b) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #108      +/-   ##
============================================
- Coverage     72.67%   72.59%   -0.08%     
- Complexity      598      599       +1     
============================================
  Files            93       93              
  Lines          1826     1828       +2     
  Branches        186      187       +1     
============================================
  Hits           1327     1327              
  Misses          453      453              
- Partials         46       48       +2     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/seedu/address/model/person/Remark.java 50.00% <0.00%> (-12.50%) 5.00 <0.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 975ec8b...6f79eb7. Read the comment docs.

Copy link

@yaowei-soc yaowei-soc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…eiyiping/tp into refactor/add-assertions-remark

# Conflicts:
#	src/main/java/seedu/address/model/person/Remark.java
@oeiyiping oeiyiping merged commit ec5236b into AY2021S2-CS2103T-T12-3:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants