Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: change all instances of Delete to Remove #90

Merged

Conversation

JulietTeoh
Copy link

so as to not confuse with API usage

Remove Command: removes an API endpoint from imPoster's list

I should have changed all delete to remove but please help to check.

Resolves #89

… API usage

Remove will remove an API endpoint from imPoster's list
@tjtanjin tjtanjin changed the title Reactor: change all instances of Delete to Remove Refactor: change all instances of Delete to Remove Mar 1, 2021
Copy link
Member

@tjtanjin tjtanjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :D Just a suggestion it might be cleaner to change delete to remove in the user guide before merging as well :D

@tjtanjin tjtanjin added the priority.High Must do label Mar 1, 2021
@tjtanjin tjtanjin added this to the v1.1.1 milestone Mar 1, 2021
@JulietTeoh
Copy link
Author

I will update the docs for my 2 pull requests in another issue tracker

@JulietTeoh JulietTeoh merged commit 97118c1 into AY2021S2-CS2103T-T12-4:master Mar 1, 2021
imPoster Development Board automation moved this from V1.1.1 to Completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Commands: Change DeleteCommand to RemoveCommand
2 participants