Add deadline test for PersonTest.java #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lue97
added
the
type.Chore
ivantjh
approved these changes
Apr 6, 2021
|
|
||
| editedAlice = new PersonBuilder(aliceCopy).build() | ||
| .withGoal(new Goal(Goal.Frequency.WEEKLY)) | ||
| .withMeetings(Arrays.asList(TypicalMeetings.getTypicalMeetings().clone())); |
There was a problem hiding this comment.
Actually don't have to clone right?
| Person aliceCopy = new PersonBuilder(ALICE).build(); | ||
| LocalDate date = LocalDate.of(2021, 3, 30); | ||
|
|
||
| Person editedAlice = new PersonBuilder(aliceCopy).build() |
There was a problem hiding this comment.
Just rename all aliceCopy to ALICE, shouldn't need to copy here
| // no prior meetings | ||
| editedAlice = new PersonBuilder(aliceCopy).build() | ||
| .withGoal(new Goal(Goal.Frequency.WEEKLY)) | ||
| .withMeetings(new ArrayList<>()); |
There was a problem hiding this comment.
.withMeetings(Collections.emptyList()) would be better
| @@ -21,4 +21,13 @@ | |||
| .withDate(LocalDate.now()) | |||
| .withTime(LocalTime.now()) | |||
| .build(); | |||
|
|
|||
| public static Meeting[] getTypicalMeetings() { | |||
There was a problem hiding this comment.
Can shift this to PersonTest because getTypicalMeetings() feels like I am retrieving all the meetings from TypicalMeetings but that is not the case here.
There was a problem hiding this comment.
I merely did this as TypicalPersons has a getTypicalPersons method. I suppose we could have a test equivalent of SampleDataUtil in main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.